enhanced renameat2 to support raw syscalls #2657
Open
+18
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace libc::renameat2() with libc::syscall() for broader compatibility - define syscall numbers manually for multiple architectures - update conditional compilation to support all Linux environments - expand test coverage for additional architectures added changelog entry for renameat2 support rust fmt handle all linux archs instead of explictly defining them
hz2
force-pushed
the
enhance-renameat2-portability
branch
from
be76b59 to
c841902
Compare
asomers
reviewed
Aug 26, 2025
Do you mind sharing the good reason? I am personally unfamiliar with why it is or is not a good idea, but would love to learn.
The discussion here outlined the desire to use the nix crate, but I can continue with using raw syscalls. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
libc::renameat2()withlibc::syscall()for broader compatibilitycontext: uutils/coreutils#8391
Checklist:
CONTRIBUTING.md